consistently require-import all_ssreflect instead of pieces of it #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clayrat OK by you to merge this? The main upside is avoiding a bunch of warnings (and hopefully getting Rocq compatibility for free). |
|
Hey, sorry for the long reply. I'm really not a fan of umbrella imports, is there perhaps a more fine-grained way to get rid of these warnings? I believe the Rocq thing can be mitigated by doing |
|
@clayrat but in SSR/MathComp, |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coq's stdlib will soon be reorganized, not least due to renaming of Coq. To avoid problems with this, how about only depending on
mathcomp? This is likely to be a lot more future-proof.