-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: switch to base core20 #313
base: main
Are you sure you want to change the base?
Conversation
Does the "core" selection has an effect on which versions of Ubuntu the snap runs? In one of your commits on the mathcomp school I have seen an explicit request for adwaita - can you leave a few words on the different methods? Should we maybe do both (switch core +gtk and explicitly request adwaita?) |
Adding the package explicitly did have no effect. My guess is that the package is already in the core or in the extension, so it is not added to the image. I could not find any info on there requirements implied by the choice of the base. In some sense I think it is orthogonal, it a file system image, you can run core20 on a fedora. There might be some nasty dependency on gnome on system stuff, but I checked and gnome-3-38 works on ubuntu 16.04, so I guess we are safe: I sincerely don't know why this change fixes the problem. So please double test it on your computer. |
I see, thanks! I am btw. quite sure that it did work fine on my computer (running Ubuntu 20.04 LTS) when I last tested it, but I am not sure if I tested it via the alias or via putting the executable into the path, probably the latter. |
I guess this makes a difference in terms of if ti picks up a system provoded adwaita. GTK apss likely have a lot of heuristics to find stuff and it is far from clear to me how this works together with the snap file system especially when executables are not called via the alias. |
But of course the snap should provide adwaita, and this is what should be picked up by CoqIDE. |
I do call |
I guess from a snap point of view it is a hack / stretch, but I actually prefer to put the snap image bin folder into my path and call the commands this way - with the patched I did to ocamlfind this works fine (as far as I tested it). But indeed I should also test the aliases. I am unsure what to recommend to users. Did you try mapping the bin folder into your PATH? |
Hum, Looking inside |
I meant looking into /snap/xx. For running coqide going via the snap link works reasonably well. I am not so sure about console usage of the coq ecosystem. |
@gares : I restarted the snap job since it failed CI - if it fails again we need to look into it. |
@gares : it failed again in the same way. So I there seem to be interactions between the snap base version and the host OS version. But strangely it is also Ubuntu 20 (20.04 LTS) Any thought what I can do about this? I can't merge it if it kills CI. |
I did not see the failure because it is in a plugin I did not build. |
if I'm right, then it should be a depext of z3 I guess |
83c8aaf
to
8bbd511
Compare
I was wrong, the library is there... (ABI version 6). So I don't get why it is not found... |
I will do some local tests today or tomorrow. |
8bbd511
to
7e97f1d
Compare
Apparently on my Ubuntu stdc++6 is there for compat reasons, but you can't link against it, that is the .so symlink is only available from ABI 7 to 10:
I've pushed a commit with 7 |
7d751ed
to
e5fcb51
Compare
@gares : can you please rebase this PR to main latest? |
This happens to fix missing icons in CoqIDE
Hmm - still does not pass. I guess I should have a look with local builds. |
@gares : do you remember which plugin build required |
Z3 |
This happens to fix missing icons in CoqIDE