[2023.11] [coq-lsp 0.2.0] [v8.19] Draft Windows build #399
Conversation
ejgallego
force-pushed
the
coq_lsp_8_19
branch
4 times, most recently
from
1d85f0b
to
3f21e1f
Compare
|
@ejgallego : anything I can help with? |
ejgallego
force-pushed
the
coq_lsp_8_19
branch
2 times, most recently
from
b84600a
to
64729af
Compare
Everything good, thanks! I started with the 8.19 pick, but indeed had to remove a few broken contribs. The installer seems to work good now, and it is simpler than in previous versions as I didn't have to patch Coq this time. |
|
Are you using the installer in a lecture? |
|
This particular artifact hasn't been tested yet, however the artifacts for 8.17 / 8.18 have been used by quite a few people with pretty good results I understand, including lectures. |
|
Artifact tested, working pretty well on the cases we have. [Note that the current installer still requires to config VSCode as outline in the README on coq-lsp for Windows] |
ejgallego
changed the title
ejgallego
force-pushed
the
coq_lsp_8_19
branch
2 times, most recently
from
407c024
to
6f081b6
Compare
ejgallego
force-pushed
the
coq_lsp_8_19
branch
2 times, most recently
from
9744523
to
7d35d38
Compare
ejgallego
changed the title
Changes: - Simplify some paths and logic - Updated for 8.19
ejgallego
force-pushed
the
coq_lsp_8_19
branch
2 times, most recently
from
f8724ba
to
4714da1
Compare
ejgallego
force-pushed
the
coq_lsp_8_19
branch
from
4714da1
to
19e3622
Compare
|
@MSoegtropIMC , actually there is something strange going on here (and in the sister PRs for 8.18 and 8.17) , for some reason, CoqIDE is not building correctly, I am not sure why, it seems the custom repos logic is working as intended. |
|
@ejgallego : as you might remember we always had a patched lablgtk in Windows + a few matching patches in CoqIDE. Recently this was fixed up in lablgtk upstream which requires adjustments in CoqIDE. The errors I see are in this area - I would say the patch level of CoqIDE doesn't match the version of lablgtk used. Which one is wrong is hard to tell, but I guess CoqIDE patches are missing. |
|
Btw.: I made good progress with solving the path length issue permanently. The manifest changes work fine, I just need a reliable automation for the registry change (especially on GIT runners). |
Indeed, it seems like CoqIDE patches not being applied, however the local repos seems setup correctly, bizarre. |
|
This issue is that you have "coqide.8.19.0" but an opam package with the patch exists only for coqide.8.19.2. |
|
I need to merge this upstream for all versions, but too busy with other loose ends ... |
Thanks @MSoegtropIMC , where do you see "coqide.8.19.0", I see instead:
I will be happy to help with that, just give me a heads up when you want this to land in the The setup is now standard, just adding Note that however it is strongly recommended to run the |
|
Yes, sorry - I somehow ended up browsing the initial commit where it was 8.19.0. The latest commit is indeed 8.19.2. I need to do a local test. |
Changes: