-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Better Windows Support #3366
base: master
Are you sure you want to change the base?
feature: Better Windows Support #3366
Conversation
@KartikSoneji is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As we've discussed in Discord, please only make the changes necessary to support Windows (no CI changes).
There are also so many more commands that the CLI makes use of — are you sure these are all the changes we need?
I'll move the CI commits to a separate branch. |
You can find all of them by searching for However, it seems strange to me that Rust doesn't already take care of making commands work by their name on Windows by default. Do all CLIs that want to support Windows have to run In any case, we could just implement a |
Ah so this is actually a quirk of node and node based executables.
Running But |
Windows Fixes
anchor init
anchor build
and Can't get home directory path: environment variable not found #1337
build-sbf
Home Directory Error on Windows anza-xyz/agave#3597 but workaround needed till unpatched versions are supported.cmd
suffix (likenpm.cmd
)this PR adds a
PackageManager::executable_name()
method to return the correct name based on the OSnpm
but instead exits with the errorprogram not found
Release Improvements
Provides prebuilt binaries for
anchor
andavm
TODO: The avm install script still needs to be changed to use the prebuilt binaries instead of building from source.