Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-integration] Change k8s.container.name to k8s.pod.name in subsystem attributes list #281

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Aug 22, 2023

Description

We preferably want to include higher-level objects in the subsystem name (deployment, stateful set, pod etc.) instead of the container name, which is too specific. This small fix changes the container name attribute to pod name to pick correct attributes for pod.

How Has This Been Tested?

Locally

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

Signed-off-by: Matej Gera <[email protected]>
@povilasv povilasv merged commit fafedb6 into coralogix:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants