Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-agent] allow setting cluster name #288

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Sep 13, 2023

Description

Allow users to easily set clusterName.

Tested with kind cluster:

helm install --values new-values.yaml otel-agent .  

My example generated:

        resource/metadata:
          attributes:
          - action: upsert
            key: k8s.cluster.name
            value: 'kind'
          - action: upsert
            key: cx.otel_integration.name
            value: coralogix-otel-agent-helm

Fixes https://coralogix.atlassian.net/browse/ES-21

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review September 13, 2023 11:36
@povilasv povilasv requested a review from matej-g September 13, 2023 11:51
@povilasv povilasv merged commit 6bc48a4 into master Sep 13, 2023
2 of 3 checks passed
@povilasv povilasv deleted the add-cluster-name branch September 13, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants