[ecs-ec2] Update default configs #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royfur
requested review from
avivgold098,
ShauliSolomovich,
povilasv,
oded-dd,
matej-g and
nicolastakashi
as code owners
juan-coralogix
approved these changes
Dec 13, 2023
frank-ang
reviewed
Dec 13, 2023
| @@ -63,20 +68,28 @@ exporters: | |||
| application_name: "$APP_NAME" | |||
| subsystem_name: "$SUB_SYS" | |||
| application_name_attributes: | |||
| - "aws.ecs.cluster" | |||
| - "aws.ecs.cluster.name" | |||
| - "aws.ecs.task.definition.family" | |||
There was a problem hiding this comment.
should be "aws.ecs.task.family"
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor#amazon-ecs
frank-ang
reviewed
Dec 13, 2023
| @@ -63,20 +68,28 @@ exporters: | |||
| application_name: "$APP_NAME" | |||
| subsystem_name: "$SUB_SYS" | |||
| application_name_attributes: | |||
| - "aws.ecs.cluster" | |||
| - "aws.ecs.cluster.name" | |||
There was a problem hiding this comment.
Correcting names and suggest in descending specific-ness.
- "aws.ecs.task.arn"
- "aws.ecs.task.family"
- "aws.ecs.cluster.arn"
frank-ang
reviewed
Dec 13, 2023
Comment on lines
+75
to
+76
| - "aws.ecs.container.name" | ||
| - "aws.ecs.docker.name" |
There was a problem hiding this comment.
Not sure if valid. Seems not documented at https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor#amazon-ecs
Maybe just use "aws.ecs.task.family"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the default configs taken from the CF template
How Has This Been Tested?
Checklist: