Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otel exporter otlp endpoint example value #347

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

YonatanKiron
Copy link
Contributor

Description

The environment variable default value should contain a prefix of http or https.
Once using an internal k8s value, the most common usage would be a http prefix

How Has This Been Tested?

Deployed the chart with and without the change;

  • without the agent's failure to report data

Checklist:

  • I have updated the relevant Helm chart(s) version(s) --> No need, it's docs change
  • I have updated the relevant component changelog(s) --> No need, it's docs change
  • This change does not affect any particular component (e.g. it's CI or docs change)

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2023

CLA assistant check
All committers have signed the CLA.

@YonatanKiron YonatanKiron added the skip changelog Won't require a changelog update check to pass. label Dec 17, 2023
@royfur royfur merged commit 072d480 into master Dec 18, 2023
4 of 5 checks passed
@royfur royfur deleted the bugfix/fix-otel-exporter-otlp-endpoint-example-value branch December 18, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Won't require a changelog update check to pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants