Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-integration] Change default value for metrics telemetry service address #477

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[opentelemetry-integration] Change default value for metrics telemetry service address #477

merged 2 commits into from
Nov 29, 2024

Conversation

douglascamata
Copy link
Contributor

Description

Fixes ES-386

How Has This Been Tested?

Locally with kind.

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@douglascamata
Improve changelog entry
82480fd 
Signed-off-by: Douglas Camata <[email protected]>
daidokoro
daidokoro approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douglascamata douglascamata merged commit e10fb90 into master Nov 29, 2024
7 checks passed
@douglascamata douglascamata deleted the otel-integration-fix-default-tel-metrics-server-address branch November 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daidokoro daidokoro daidokoro approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglascamata @daidokoro