-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADCIO-4651) refactor: refactor switch component #111
base: main
Are you sure you want to change the base?
Conversation
876f508 |
return ( | ||
<label ref={ref} {...props} className={cx(classes.root)}> | ||
<input | ||
type="checkbox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type="checkbox" | |
type="checkbox" | |
role="switch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์ ๊ฐ์ ์ ๊ทผ์ฑ์ด๋ ๊ธฐํ ์ธํฐํ์ด์ค ๋๋ฌธ์
https://react-spectrum.adobe.com/react-aria/Switch.html๋ฅผ ๋ํ์์ ์ฐ๋๊ฒ ์ข์๊ฒ ๊ฐ์ต๋๋ค.
์๋๋ฉด ํญ ์ธ๋ฑ์ค, ํฌ์ปค์ค, ํค๋ณด๋ ๋ฑ ์ค์ ๋ก ์ฌ์ฌ์ฉํ๊ฒ ํ๋ ค๋ฉด ์ ๊ฒฝ์ธ๊ป ๋ง๊ฑฐ๋ ์.
https://www.jollyui.dev/docs/components/switch ๋ฅผ ๋ณด๋ฉด react-aria-component๋ก ์ด๋ป๊ฒ ์ปค์คํ ํ๋์ง ๋ณผ ์ ์์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ ๋ณต์กํ๊ณ cds์๋ง ์๋ ํน์ํ ์ปดํฌ๋ํธ๊ฐ ์๋๋ผ๋ฉด ๋๋ถ๋ถ react-aria ์ฐ๋ฉด ์ด๋จ๊น ์ถ์ด์
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ค๋ค ์๊ฒฌ ๊ฐ์ฌํฉ๋๋ค ใ ใ ๊ทธ๋ ๊ฒ ์์ ํ ๋ฆฌ๋ทฐ ์์ฒญ ๋๋ฆด๊ฒ์~
๐ Jira Ticket Number
โป๏ธ Current situation
๐ก Proposed solution
2024-07-29.7.49.17.mov
switch ์ปดํฌ๋ํธ ์คํ์ผ๋ง์ emotion์์ pandacss๋ก ๋ฐ๊ฟ๋๋ค.
โ Additional Information
๐งช Testing
๐งโ๐ป Reviewer Nudging
โ Checklist