Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADCIO-4651) refactor: refactor switch component #111

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dev-redo
Copy link
Member

@dev-redo dev-redo commented Jul 29, 2024

๐Ÿ”— Jira Ticket Number

โ™ป๏ธ Current situation

๐Ÿ’ก Proposed solution

2024-07-29.7.49.17.mov

switch ์ปดํฌ๋„ŒํŠธ ์Šคํƒ€์ผ๋ง์„ emotion์—์„œ pandacss๋กœ ๋ฐ”๊ฟ‰๋‹ˆ๋‹ค.

โž• Additional Information

๐Ÿงช Testing

๐Ÿง‘โ€๐Ÿ’ป Reviewer Nudging

โœ… Checklist

  • ์ˆ˜์ • ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ๋งˆ์ณค์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ๋…ธ์…˜ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋””์ž์ธ ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ์˜ ๊ฒฝ์šฐ rmp PR ๋ฒˆํ˜ธ ์ฒจ๋ถ€ ๋ฐ CDS ๋ผ๋ฒจ์„ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

@dev-redo dev-redo self-assigned this Jul 29, 2024
@dev-redo dev-redo changed the title ADCIO-4651) ADCIO-4651) refactor: refactor switch component Jul 29, 2024
@lebmouse
Copy link
Collaborator

876f508
์š”๋Ÿฐ์‹์œผ๋กœ ํ•˜๋ฉด ์ข€ ๋” ์Šค์œ„์น˜ ๋ฃจํŠธ๊ฐ’์— ๋ฐ˜์‘์ ์ด๊ณ , ์ •์ ์ธ ๊ฐ’์„ ๋œ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์„๊ฒƒ ๊ฐ™์€๋ฐ ์–ด๋– ์‹ ๊ฐ€์š”??

return (
<label ref={ref} {...props} className={cx(classes.root)}>
<input
type="checkbox"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type="checkbox"
type="checkbox"
role="switch"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์œ„์™€ ๊ฐ™์€ ์ ‘๊ทผ์„ฑ์ด๋ž‘ ๊ธฐํƒ€ ์ธํ„ฐํŽ˜์ด์Šค ๋•Œ๋ฌธ์—
https://react-spectrum.adobe.com/react-aria/Switch.html๋ฅผ ๋ž˜ํ•‘์—์„œ ์“ฐ๋Š”๊ฒŒ ์ข‹์„๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

์™œ๋‚˜๋ฉด ํƒญ ์ธ๋ฑ์Šค, ํฌ์ปค์Šค, ํ‚ค๋ณด๋“œ ๋“ฑ ์‹ค์ œ๋กœ ์žฌ์‚ฌ์šฉํ•˜๊ฒŒ ํ•˜๋ ค๋ฉด ์‹ ๊ฒฝ์“ธ๊ป˜ ๋งŽ๊ฑฐ๋“ ์š”.

https://www.jollyui.dev/docs/components/switch ๋ฅผ ๋ณด๋ฉด react-aria-component๋กœ ์–ด๋–ป๊ฒŒ ์ปค์Šคํ…€ํ•˜๋Š”์ง€ ๋ณผ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-07-30 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 8 58 29

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋„ ๋ณต์žกํ•˜๊ณ  cds์—๋งŒ ์žˆ๋Š” ํŠน์ˆ˜ํ•œ ์ปดํฌ๋„ŒํŠธ๊ฐ€ ์•„๋‹ˆ๋ผ๋ฉด ๋Œ€๋ถ€๋ถ„ react-aria ์“ฐ๋ฉด ์–ด๋–จ๊นŒ ์‹ถ์–ด์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค๋“ค ์˜๊ฒฌ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ใ…Žใ…Ž ๊ทธ๋ ‡๊ฒŒ ์ˆ˜์ • ํ›„ ๋ฆฌ๋ทฐ ์š”์ฒญ ๋“œ๋ฆด๊ฒŒ์š”~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants