-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
R3SOL-372 Extract Uniqueness code to a library (#6370)
Main changes in this PR: - `BackingStore` and `UniquenessChecker` interfaces are now part of the `ledger-lib-uniqueness` library - The `BackingStore` logic is basically common for C5 and DLT except for how we establish the DB connection. That's the reason we have a base abstract class now called `JPABackingStoreBase`. Both C5 and DLT will inherit from this. In C5 it's called `JPABackingStoreOsgiImpl` and the entity manager is acquired through `DbConnectionManager`. - Thankfully the core uniqueness checker logic is the same for C5/DLT so only C5 will extend `BatchedUniquenessCheckerImpl` with the necessary OSGi things. - `BatchedUniquenessCheckerImplTest` tests the main UniquenessChecker logic - `JPABackingStoreOsgiImplIntegrationTests`, `JPABackingStoreEntitiesIntegrationTest` tests BackingStore in C5. We will have testcontainers integration tests in DLT. - `JPABackingStoreOsgiImplBenchmark` still exists and still works. - `UniquenessCheckerImplDBIntegrationTests` is the integration test for C5, will have testcontainers version in DLT. Co-authored-by: nkovacsx <[email protected]>
- Loading branch information
Showing
3 changed files
with
14 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters