R3SOL-0 Remove hibernate dependency from ledger persistence lib #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
blsemo
reviewed
Oct 22, 2024
| override fun findSignedTransactionIdsAndStatuses( | ||
| transactionIds: List<String> | ||
| ): Map<SecureHash, String> { | ||
| return entityManagerFactory.transaction { em -> | ||
| repository.findSignedTransactionIdsAndStatuses(em, transactionIds) | ||
| entityManagerFactory.createEntityManager().use { em -> |
There was a problem hiding this comment.
Why did you have to remove the transaction here?
|
Jenkins build for PR 6368 build 26 Build Successful: |
driessamyn
force-pushed
the
driessamyn/spike/remove-hibernate-from-ledger-persistence
branch
from
ff03825 to
9260f63
Compare
driessamyn
changed the title
…fDoesNotExist` case. NOTE: includes a lot of println lines for debugging, will be removed once verified.
|
lankydan
approved these changes
Oct 31, 2024
driessamyn
deleted the
driessamyn/spike/remove-hibernate-from-ledger-persistence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Hibernate dependency from the ledger-persistence lib.