R3SOL-535 Extract verification logic to the ledger library #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 6376 build 8 Build Successful: |
blsemo
reviewed
Oct 31, 2024
...main/kotlin/net/corda/ledger/libs/verification/impl/UtxoLedgerUtxoTransactionVerifierImpl.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| abstract class UtxoTransactionVerifier { | ||
| protected open val subjectClass: String = "transaction" | ||
| object VerificationUtils { |
There was a problem hiding this comment.
What's the advantage of putting these functions into an object?
There was a problem hiding this comment.
Do you mean have them as top level functions instead?
…da-runtime-os into nandor/R3SOL-535/extract-verification
lankydan
reviewed
Nov 4, 2024
...b-verification/src/main/kotlin/net/corda/ledger/libs/verification/UtxoTransactionVerifier.kt
Show resolved
Hide resolved
...src/main/kotlin/net/corda/ledger/libs/verification/impl/UtxoLedgerTransactionVerifierImpl.kt
Outdated
Show resolved
Hide resolved
lankydan
approved these changes
Nov 5, 2024
lankydan
approved these changes
Nov 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.