Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R3SOL-0 - remove hibernate from uniqueness cherry picked #6380

Conversation

driessamyn
Copy link

Remove the need for hibernate and javax.persistence in the uniqueness lib.

@driessamyn driessamyn requested a review from a team as a code owner November 4, 2024 15:44
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES|DA5|DI|R3SOL)-\d+)(.*)

@driessamyn driessamyn force-pushed the driessamyn/remove-hibernate-from-uniqueness-cherry-picked branch from 51fa2da to a27002f Compare November 4, 2024 15:45
@driessamyn driessamyn changed the title R3SOL0 - remove hibernate from uniqueness cherry picked R3SOL-0 - remove hibernate from uniqueness cherry picked Nov 4, 2024
@github-actions github-actions bot dismissed their stale review November 4, 2024 15:45

All good!

Copy link

sonarqubecloud bot commented Nov 4, 2024

@nkovacsx nkovacsx self-requested a review November 4, 2024 16:09
Copy link
Contributor

@nkovacsx nkovacsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 6380 build 1

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1730735141998
Helm chart version produced by this PR: 5.3.0-alpha.1730735141998
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6380/corda
Helm chart Polaris score: 82

@driessamyn
Copy link
Author

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 4, 2024

Building E2E Tests on PR-6380

Succeeded

@lankydan lankydan merged commit 69bc093 into feature/ledger-library Nov 5, 2024
7 checks passed
@lankydan lankydan deleted the driessamyn/remove-hibernate-from-uniqueness-cherry-picked branch November 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants