-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core-16349: corda 5 Kotlin negotiation app #21
base: main
Are you sure you want to change the base?
Conversation
// The CorDapp uses the slf4j logging framework. Corda-API provides this so we need a 'cordaProvided' declaration. | ||
cordaProvided 'org.slf4j:slf4j-api' | ||
|
||
// This are shared so should be here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block should probably be deleted
// The CorDapp uses the slf4j logging framework. Corda-API provides this so we need a 'cordaProvided' declaration. | ||
cordaProvided 'org.slf4j:slf4j-api' | ||
|
||
// Dependencies Required By Simulator Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, where are the gradle files, and config file for deployment?
… into Dhruv/Core-16349_negotiation_kt
… into Dhruv/Core-16349_negotiation_kt
|
var flowEngine: FlowEngine? = null | ||
|
||
@Suspendable | ||
override fun call(requestBody: ClientRequestBody): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does ProposalFlow return a string? Is it not supposed to return a UUID? Taking into account that Accept and Modify flows seem to be expecting the proposal ID to be a UUID
- updated accept contract verification - Resolved hanging flows bug - updated readme.md
"clientRequestId": "AcceptFlow", | ||
"flowClassName": "com.r3.developers.samples.negotiation.workflows.Accept.AcceptFlowRequest", | ||
"requestBody": { | ||
"proposalID": "<use the proposal id here>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the variable acceptor, but why do you need this input?
The accepter can only be the proposee of the proposal. In the contract, you can just use the proposee variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterli-r3 I've added the Acceptor to the documentation. We still need to know who is trying to accept the trade to be able to perform the necessary checks in the Accept contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @khutsijabari , I had quickly chatted with @7Dhruv eariler, You dont really need to add a variable to keep track of the proposer. You can check it in two ways:
- Check if the proposer with myInfo in the AcceptProposal flow initiator.
- Make the accept command take input, we can pass in the myInfo into the contract via the command.
The idea is that we will try to have as less variables as possible in the states.
No description provided.