-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add a "Creating derived configs" section #265
base: main
Are you sure you want to change the base?
Conversation
2afa1c1
to
197d23d
Compare
Oh well that's just super cool how the docs are CI tested rustdoc style. Nice work! (edit: I mean, nice work whoever wrote the testing code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either move this to OCP docs, or substantially cut down the explanation. Outside of OCP this isn't an operation users should generally need to perform, because it assumes that (1) users are injecting machine-specific configuration fragments (which we should strongly discourage in favor of DHCP and DNS) and (2) the original worker.ign
isn't under their control (which is only true if it's generated by an outside tool like openshift-install).
If we want to keep this here, we could drop most of the explanatory text and just give a couple examples:
- merging an external config over HTTP (preferred), and
- merging it from a local directory (if necessary).
Sure, but we clearly need to support static IP addressing etc. too right? And if we support it it should be documented.
It's an interesting topic. I could imagine this happening outside of OpenShift 4 too. Like a "base operating system" group maintaining their tweaked base config, and then for some special machines they derive from that config in a similar way. Dunno. If you feel strongly I can move this just to the OCP docs for now. |
197d23d
to
98d6e39
Compare
Comments addressed! |
Any further thoughts on this? |
Thinking about it some more, I think the doc as written (with In general, we should encourage users to maintain a library of configs that can be merged by the root config, with any machine-specific configuration (e.g. static IP) placed directly in the root config. So the root might look like:
The OCP case is a bit weird because |
xref openshift/machine-config-operator#1720
This also came up in e.g.
https://github.com/coreos/fedora-coreos-docs/pull/264/files#diff-089ac9657fd668d3f0f2d3dcb663fe1c75e72aaefac2ff1d78ae70c9cf96e46eR185