Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert basic tests (cosa kola --basic-qemu-scenarios) to a denylist-able one #3418

Closed
travier opened this issue Apr 4, 2023 · 1 comment · Fixed by #3652
Closed

Convert basic tests (cosa kola --basic-qemu-scenarios) to a denylist-able one #3418

travier opened this issue Apr 4, 2023 · 1 comment · Fixed by #3652
Assignees
@marmijo
Labels
jira for syncing to jira

Comments

@travier
Copy link
Member

travier commented Apr 4, 2023 •
edited
Loading

Feature Request

Enable deny-listing of tests in cosa kola --basic-qemu-scenarios to be able to use the kola deny list to skip secure boot tests on some arches/variants for example.

Similar in spirit to the work done in #3298

See: openshift/os#1237 & openshift/os#1238
@jlebon
Copy link
Member

jlebon commented Apr 4, 2023 •
edited
Loading

The fix for this I think is to actually make those tests proper kola tests. This will give us denylisting and other things for free, while thinning out cmd-kola (which I think we should get rid of eventually).

So e.g. on x86_64, we'd have

  • basic.bios
  • basic.uefi
  • basic.uefi-secure

@travier travier mentioned this issue Apr 4, 2023
Merged
@dustymabe dustymabe added the jira for syncing to jira label Jun 9, 2023
@travier travier mentioned this issue Jun 9, 2023
Open
@Adam0Brien Adam0Brien self-assigned this Jun 28, 2023
@Adam0Brien Adam0Brien mentioned this issue Jul 11, 2023
Closed
@marmijo marmijo assigned marmijo and unassigned Adam0Brien Oct 19, 2023
prestist added a commit to prestist/coreos-assembler that referenced this issue Nov 7, 2023
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
855ab6b 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
@prestist prestist mentioned this issue Nov 7, 2023
Merged
prestist added a commit to prestist/coreos-assembler that referenced this issue Nov 8, 2023
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
a3daccd 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Nov 9, 2023
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
e3fc4fb 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Nov 14, 2023
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
f9e2571 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Dec 5, 2023
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
f854f01 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Feb 8, 2024
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
a899889 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Feb 27, 2024
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
d00ff47 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Feb 27, 2024
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
c02cff5 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
prestist added a commit to prestist/coreos-assembler that referenced this issue Mar 12, 2024
@prestist @Adam0Brien
mantle/kola: copy basic tests into formal kola workflow
099619c 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
jlebon pushed a commit to prestist/coreos-assembler that referenced this issue Apr 14, 2024
@prestist @Adam0Brien @jlebon
mantle/kola: copy basic tests into formal kola workflow
2f44daa 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes coreos#3418

co-authored-by: AdamOBrien <[email protected]>
jlebon pushed a commit that referenced this issue Apr 16, 2024
@prestist @Adam0Brien @jlebon
mantle/kola: copy basic tests into formal kola workflow
6775ab1 
`cmd-kola` has non-conformed basic kola tests. These tests do not
benefit from the supporting functionality around kola test's such as
denylisting or other functionality. reduce `cmd-kola` and conform
the basic kola tests.

fixes #3418

co-authored-by: AdamOBrien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmijo marmijo

Labels
jira for syncing to jira
Projects
None yet
Milestone
No milestone
5 participants
@dustymabe @jlebon @marmijo @travier @Adam0Brien