-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mantle/kola/tests: Make basic kola tests denylist-able #3531
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adam0Brien Great job! We will also need to remove the calls from cmd-kola, we don't need it anymore.
I tested the changes and the denylist: [root@localhost builder]# cosa kola run basic.bios
|
@@ -112,6 +112,8 @@ type Test struct { | |||
// Conflicts is non-empty iff nonexclusive is true | |||
// Contains the tests that conflict with this particular test | |||
Conflicts []string | |||
|
|||
Nvme bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add the nvme
you still need to touch the mantle/kola/harness.go
to make use of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this what you mean?
https://github.com/coreos/coreos-assembler/pull/3531/files#diff-9db99bb7fefa41cf89f75a965efa109bc8349ab0a55fdb093fa46775724791cbR1008
or am i missing something else?
3d55de4
to
78f1e7c
Compare
9a7d127
to
84b26a3
Compare
6384a32
to
a9b6c8e
Compare
/retest-required |
5df91d0
to
19a0733
Compare
@Adam0Brien: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this PR, I have cherry-picked these changes into a new PR @Adam0Brien Thank you for all of your work on this you got this issue very far and I was happy to learn from what you did. |
Fix: #3418