kola/testiso: enable 4k images tests for s390x #3574
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-dubrovskii
force-pushed
the
s390x_4k_isotest
branch
from
7101de4 to
e05f837
Compare
nikita-dubrovskii
changed the title
dustymabe
previously approved these changes
Aug 22, 2023
nikita-dubrovskii
force-pushed
the
s390x_4k_isotest
branch
from
e05f837 to
7a15b48
Compare
nikita-dubrovskii
changed the title
nikita-dubrovskii
force-pushed
the
s390x_4k_isotest
branch
from
7a15b48 to
075c52a
Compare
nikita-dubrovskii
force-pushed
the
s390x_4k_isotest
branch
from
075c52a to
0dad896
Compare
|
any reason we have the |
Probably because of:
|
nikita-dubrovskii
force-pushed
the
s390x_4k_isotest
branch
from
0dad896 to
d14b97d
Compare
nikita-dubrovskii
added
hold
dustymabe
reviewed
Jan 13, 2025
Comment on lines
+106
to
+113
| "iso-live-login.4k.s390fw", | ||
| "iso-offline-install.s390fw", | ||
| // https://github.com/coreos/fedora-coreos-tracker/issues/1434 | ||
| // "iso-offline-install.mpath.s390fw", | ||
| // https://github.com/coreos/fedora-coreos-tracker/issues/1261 | ||
| // "iso-offline-install.4k.s390fw", | ||
| "iso-offline-install.4k.s390fw", | ||
| "iso-offline-install.mpath.s390fw", | ||
| "pxe-online-install.s390fw", | ||
| "pxe-online-install.4k.s390fw", | ||
| "pxe-offline-install.s390fw", | ||
| "miniso-install.s390fw", | ||
| "pxe-offline-install.4k.s390fw", |
There was a problem hiding this comment.
I don't think we should enable so many 4k tests. The goal here is we get a strategic covering of the possible scenarios without trying to cover them all. i.e. let's add maybe 2 or 3 versus 5. Or maybe we can convert some other tests that are running into 4k ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue seems to be obsolete, but we still have to wait for a new
coreos-installer.rpmDepends on: ibm-s390-linux/s390-tools#154