[mantle/kola] Fix test loading logic with symlinks

[jbtrystram]

Added a separate block to address symlinks loading. It should work with nested symlinks, as it simply recurse calls with the resolved path, but I have not tested it.

Fixes #3135

Related : #3204

[jbtrystram]

with further testing, this code does resolve nest symlinks, as it does now pickup the following test: ext.config.shared.root-reprovision.luks.autosave-xfs.data.luks-test.sh

which is a symlink : https://github.com/coreos/fedora-coreos-config/tree/2c9ab8ccc577cd3fc9efa9b15bed773415718d81/tests/kola/root-reprovision/luks/autosave-xfs

[openshift-ci]

@jbtrystram: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/rhcos	52e2e91	link	true	/test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dustymabe]

Is there really any functionality currently missing?

From what I understand we don't actually want to run luks-test.sh directly. It's in the data directory because it's called by ext.config.shared.root-reprovision.luks and ext.config.shared.root-reprovision.luks.autosave-xfs. i.e. It's shared code for two tests, not a test that stands on its own.

[jbtrystram]

Is there really any functionality currently missing?

Not really, but a regression was introduced in #3082 and it was not really fixed (reverted, but the follow-up work was not completed)
See #3135

[dustymabe]

Is there really any functionality currently missing?

Not really, but a regression was introduced in #3082 and it was not really fixed (reverted, but the follow-up work was not completed) See #3135

I see. Though it does look like the ioutil.Readdir -> os.ReadDir migration happened later in #3341.

[jbtrystram]

If I understand correctly, the conclusion is that if nested symlinks are not a needed feature we can close this, as #3135 was fixed, and #3341 did not re-break them :)

[dustymabe]

That is my understanding. @travier am I missing something?

[travier]

Can we double check that all shared tests are running on RHCOS as expected? If this not needed anymore then we can close everything here. Sorry for the misleading info.

[dustymabe]

I ran a kola list with and without this change and the only additional test I saw was ext.config.shared.root-reprovision.luks.autosave-xfs.data.luks-test.sh which I argue in in #3585 (comment) that we don't actually want.

[jbtrystram]

I ran a kola list with and without this change and the only additional test I saw was ext.config.shared.root-reprovision.luks.autosave-xfs.data.luks-test.sh which I argue in in #3585 (comment) that we don't actually want.

That what I get as well. Let's close this

[travier]

Great! Thanks