ci: Test virtiofsd as root #3623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
ci-rootpod
branch
5 times, most recently
from
721eca4
to
0e6a986
Compare
cgwalters
force-pushed
the
ci-rootpod
branch
from
0e6a986
to
016198a
Compare
This is just better behavior for the case of e.g. `cosa run -x "somecmd" > out.txt` to execute a command and capture the output - we don't want to intermix status stuff in there. Further, this makes it easier to test the code when not on a tty (in e.g. CI).
cgwalters
force-pushed
the
ci-rootpod
branch
from
fb83d45
to
4bc95c1
Compare
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
force-pushed
the
ci-rootpod
branch
from
4bc95c1
to
47c73b4
Compare
🎉 successfully failed. |
Work around https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/197 Basically virtiofsd should not be trying to drop capabilities when it can't do so, but we should be able to ask it to stop doing that.
|
I think we can close this now that #3625 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.