-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iscsi+multipath test; add some improvements to test strategy #3789
Commits on May 7, 2024
-
mantle/platform/qemu: Adjust dependencies on journal-stream unit
The unit kept getting killed when entering emergency.target, which isn't very useful since some of the messages that hadn't been flushed yet were the ones that revealed the root cause of the failure. Let's set up the ordering/deps such that it doesn't get taken down when entering emergency.target. Also add a sleep 1 in the Destroy to allow for some remaining messages to get flushed.
Configuration menu - View commit details
-
Copy full SHA for 21188ab - Browse repository at this point
Copy the full SHA 21188abView commit details -
mantle/platform/qemu: drop json formatting from journal output
In my experience the value of this has been little to none. It mostly just forces us to filter this output through jq -r .MESSAGE Let's make it just output text like the non-testiso journal.txt files are today.
Configuration menu - View commit details
-
Copy full SHA for f06767d - Browse repository at this point
Copy the full SHA f06767dView commit details -
mantle/kola/testiso: fix firmware entries for multi-arch iscsi tests
There's no bios on aarch64, ppc64le or s390x.
Configuration menu - View commit details
-
Copy full SHA for cc18190 - Browse repository at this point
Copy the full SHA cc18190View commit details -
mantle/kola: drop unnecessary kargs for iscsi tests
The ip=ibft seems to only dictate what interface to use when bringing up networking, but isn't important if you are using DHCP IIUC. The rd.iscsi.initiator also isn't important here. It appears to work without it.
Configuration menu - View commit details
-
Copy full SHA for 7b9d3da - Browse repository at this point
Copy the full SHA 7b9d3daView commit details -
mantle/kola/testiso: switch one iscsi test to use uefi
This will help get more test coverage.
Configuration menu - View commit details
-
Copy full SHA for 6ca617c - Browse repository at this point
Copy the full SHA 6ca617cView commit details -
mantle/kola: make options to iscsiadm long options
Makes it a little bit easier for the reader to understand what the options are doing without having to study the iscsiadm man page.
Configuration menu - View commit details
-
Copy full SHA for 3c5b777 - Browse repository at this point
Copy the full SHA 3c5b777View commit details -
mantle/kola: use random uuid for ipxe initiator-iqn
We can use a random value here because we don't have ACL's enabled for this test. Let's just make it a random UUID to make it more clear the value isn't significant.
Configuration menu - View commit details
-
Copy full SHA for a3d49ea - Browse repository at this point
Copy the full SHA a3d49eaView commit details -
mantle/kola: login from discovery mode
This has the same effect, just uses one fewer command!
Configuration menu - View commit details
-
Copy full SHA for 9e6f0f8 - Browse repository at this point
Copy the full SHA 9e6f0f8View commit details -
mantle/kola: use OnFailureJobMode=isolate for iscsi test units
When we go to emergency.target it's standard to use OnFailureJobMode=isolate.
Configuration menu - View commit details
-
Copy full SHA for 1f96d25 - Browse repository at this point
Copy the full SHA 1f96d25View commit details -
mantle/kola: simplify naming of iscsi targets
The format doesn't need the extra pieces, which might be confused as important. Let's use the simplest possible name here.
Configuration menu - View commit details
-
Copy full SHA for dcf3f71 - Browse repository at this point
Copy the full SHA dcf3f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f7f345 - Browse repository at this point
Copy the full SHA 4f7f345View commit details -
mantle/kola/testiso: add iscsi test for multipath on top of iscsi
Here we modify the iscsi setup to define two ports `:0` and `:1` that both expose the same underlying block device, which means that multipath can be set up on top of those two paths. We then add a new test that provides `root=/dev/disk/by-label/dm-mpath-root` and `rd.multipath=default` to the kernel command line to perform the test. Note that this modifies the targetd setup and the iPXE config for all of the tests, but they still work fine, just accessing `:0` and leaving `:1` alone.
Configuration menu - View commit details
-
Copy full SHA for d7d352d - Browse repository at this point
Copy the full SHA d7d352dView commit details