kola: refactor and add support for warn: true tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the arguments and error handling for `kola` into a runKola closure to make it easier to manage. Most calls in this file use mostly the same arguments, so this is a nice cleanup. This commit also adds the `--on-warn-failure-exit-77` option [1] and adds handling to mark a test as `warn()` if that happens versus the typical `error()`. [1] coreos/coreos-assembler#3551
dustymabe
requested review from
jlebon,
ravanelli,
mike-nguyen and
gursewak1997
as code owners
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the arguments and error handling for
kolainto a runKola closure to make it easier to manage. Most calls in this file use mostly the same arguments, so this is a nice cleanup.This commit also adds the
--on-warn-failure-exit-77option [1] and adds handling to mark a test aswarn()if that happens versus the typicalerror().[1] coreos/coreos-assembler#3551