Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next-devel] overrides: fast-track grub packages: 2.12-10.fc41 #3190

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[next-devel] overrides: fast-track grub packages: 2.12-10.fc41 #3190

merged 1 commit into from
Oct 17, 2024

Conversation

ravanelli
Copy link
Member

@ravanelli ravanelli commented Oct 3, 2024 •
edited
Loading

@ravanelli
Copy link
Member Author

@dustymabe sorry, it has been a while I do not pin a package in next-devel 😁, I don't recall if I can open a PR directly to next-devel

@dustymabe
Copy link
Member

If we do merge this we'll need to account for some grub packages being different for different architectures.

I'm not sure we should merge it or not, though. Since it's only in next right now and we've already shipped it and the impact is small (i.e. new systems on VMWare) then maybe we should wait and see if the GRUB devs can figure out the problem soon rather than reverting (i.e. downgrading GRUB in the next next release) for now.

@ravanelli ravanelli changed the title [next-devel] overrides: pin grub: 22.06.124.fc41 fuse:2.9.9-21.fc41 [next-devel] overrides: fast-track grub packages: 2.12-10.fc41 Oct 17, 2024
@ravanelli ravanelli force-pushed the pr/vmware branch 4 times, most recently from 1f9f405 to fb97555 Compare October 17, 2024 13:24
@dustymabe
Copy link
Member

I think there are a few ppc64le grub specific packages too aren't there?

@ravanelli
Copy link
Member Author

I think there are a few ppc64le grub specific packages too aren't there?

Ahh, Indeed! fixed!

dustymabe
dustymabe reviewed Oct 17, 2024
View reviewed changes
manifest-lock.overrides.ppc64le.yaml Outdated
reason: https://github.com/coreos/fedora-coreos-tracker/issues/1802
type: fast-track
grub2-ppc64le-modules:
evra: 1:2.12-10.fc41.ppc64le
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is noarch for some reason:

Suggested change
evra: 1:2.12-10.fc41.ppc64le
evra: 1:2.12-10.fc41.noarch 
$ grep -A 1 grub2- manifest-lock.ppc64le.json 
    "grub2-common": {
      "evra": "1:2.12-9.fc41.noarch",
--
    "grub2-ppc64le": {
      "evra": "1:2.12-9.fc41.ppc64le",
--
    "grub2-ppc64le-modules": {
      "evra": "1:2.12-9.fc41.noarch",
--
    "grub2-tools": {
      "evra": "1:2.12-9.fc41.ppc64le",
--
    "grub2-tools-minimal": {
      "evra": "1:2.12-9.fc41.ppc64le",

@ravanelli
overrides: fast-track grub packages: 2.12-10.fc41
facd1f6 
- VMWare OVA Fails To Boot due grub serial bug;
- Fast track packages with the fix.
See: coreos/fedora-coreos-tracker#1802

Signed-off-by: Renata Ravanelli <[email protected]>
dustymabe
dustymabe approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) October 17, 2024 14:05
@dustymabe dustymabe mentioned this pull request Oct 17, 2024
Closed
@dustymabe dustymabe merged commit 31802d2 into coreos:next-devel Oct 17, 2024
1 check passed
@dustymabe dustymabe mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravanelli @dustymabe