-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use the exttests container #677
base: testing-devel
Are you sure you want to change the base?
Conversation
This is an incremental step to test out running exttests. But hopefully soon want we do is go multi-pod/multi-stage and split off exttests separately - we may not always want to gate on them, etc.
From Jenkins logs looks like it worked!
|
To recap with this we have a flow where:
Or in other words, we run upstream tests on both upstream builds and our pipeline without duplicating the tests. |
cosaPod { | ||
// Use the exttests container here in CI to get extra coverage; xref | ||
// https://github.com/coreos/coreos-assembler/pull/1745 | ||
cosaPod(image: "registry.svc.ci.openshift.org/coreos/cosa-exttests:latest") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a strong preference for having CI keep using the canonical cosa image from quay.io for all the main steps. It's what devs use locally. We've also had multiple encounters with OpenShift CI having stale versions of cosa or rebuilds of layered images like this not triggering. It's a major pain to debug.
How about instead we add sugar to coreos-ci-lib to have the exttest container be added to the pod and then for the kola run, it knows to use the exttest container just for the installed tests? (I.e. using container("exttests") { ... }
).
Hmm, or maybe it is indeed easier to just fold this into cosa for now until we do something fancier as discussed in coreos/coreos-assembler#1745.
denylist: add crio.base
This is an incremental step to test out running exttests.
But hopefully soon want we do is go multi-pod/multi-stage
and split off exttests separately - we may not always
want to gate on them, etc.