-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorial: Update systemd user example docs #458
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing directories to Butane configuration Adjust file permissions in Butane configuration Fixes coreos#367 Signed-off-by: Erik Sjölund <[email protected]>
travier
changed the title
tutorial: Update systemd user example docs (#458)
tutorial: Update systemd user example docs
Sep 19, 2022
travier
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit but LGTM. Thanks!
travier
requested changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
travier
reviewed
Sep 19, 2022
travier
reviewed
Sep 19, 2022
travier
reviewed
Sep 19, 2022
travier
reviewed
Sep 19, 2022
travier
reviewed
Sep 19, 2022
This was referenced Sep 19, 2022
Thanks for the draft here. I've pushed an updated version in #460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing directories to Butane configuration
Adjust file permissions in Butane configuration
Fixes #367
A side-note, I created a discussion topic about what file permissions the directory ~/.config should have:
Maybe the group and the world permissions should be removed all together for the files and directories under ~/.config
?
Signed-off-by: Erik Sjölund [email protected]