Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loongarch64 GOARCH value #1942

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix loongarch64 GOARCH value #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ef7ce
build: fix GOARCH for loongarch64 (Makefile)
k0tran Sep 13, 2024
54afa54
docs: add bug fix entry for PR #1942
k0tran Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ ifeq ($(GOARCH),x86_64)
GOARCH=amd64
else ifeq ($(GOARCH),aarch64)
GOARCH=arm64
else ifeq ($(GOARCH),loongarch64)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add an item for release notes? if not I can skip them but I think it could be useful to communicate this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made additional commit with only short description.
In changelog provided broad description and left link to this PR for details

GOARCH=loong64
else ifeq ($(patsubst armv%,arm,$(GOARCH)),arm)
GOARCH=arm
else ifeq ($(patsubst i%86,386,$(GOARCH)),386)
Expand Down
1 change: 1 addition & 0 deletions docs/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ nav_order: 9
### Bug fixes

- Fix Akamai Ignition base64 decoding on padded payloads
- Fix Makefile GOARCH for loongarch64 ([#1942](https://github.com/coreos/ignition/pull/1942))

## Ignition 2.19.0 (2024-06-05)

Expand Down
Loading