Skip to content

Commit

Permalink
libpriv/scripts: Fix uint64 printing
Browse files Browse the repository at this point in the history
Yet more print format issues uncovered by users running on armv7.

Also add a space between the specifier and the "ms" because it makes one
doubtful whether printf interprets this correctly.

I think this will resolve
https://bugzilla.redhat.com/show_bug.cgi?id=1906184.
  • Loading branch information
jlebon authored and openshift-merge-robot committed Dec 9, 2020
1 parent f1488e5 commit 36614ae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/libpriv/rpmostree-scripts.c
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ impl_run_rpm_script (const KnownRpmScriptKind *rpmscript,
guint64 elapsed_ms = end_time_ms - start_time_ms;

sd_journal_send ("MESSAGE_ID=" SD_ID128_FORMAT_STR, SD_ID128_FORMAT_VAL(RPMOSTREE_MESSAGE_PREPOST),
"MESSAGE=Executed %s for %s in %ums", rpmscript->desc, dnf_package_get_name (pkg), elapsed_ms,
"MESSAGE=Executed %s for %s in %" G_GUINT64_FORMAT " ms", rpmscript->desc, dnf_package_get_name (pkg), elapsed_ms,
"SCRIPT_TYPE=%s", rpmscript->desc,
"PKG=%s", dnf_package_get_name (pkg),
"EXEC_TIME_MS=%" G_GUINT64_FORMAT, elapsed_ms,
Expand Down Expand Up @@ -1018,7 +1018,7 @@ rpmostree_transfiletriggers_run_sync (Header hdr,
(*out_n_run)++;

sd_journal_send ("MESSAGE_ID=" SD_ID128_FORMAT_STR, SD_ID128_FORMAT_VAL(RPMOSTREE_MESSAGE_FILETRIGGER),
"MESSAGE=Executed %%transfiletriggerin(%s) for %s in %ums; %u matched files",
"MESSAGE=Executed %%transfiletriggerin(%s) for %s in %" G_GUINT64_FORMAT " ms; %u matched files",
pkg_name, patterns_joined->str, elapsed_ms, n_total_matched,
"SCRIPT_TYPE=%%transfiletriggerin"
"PKG=%s", pkg_name,
Expand Down

0 comments on commit 36614ae

Please sign in to comment.