Implement basic check for container updates

coreos · Jun 28, 2023 · b20963b · b20963b
1 parent 7ad41b6
commit b20963b
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/src/daemon/rpmostree-sysroot-upgrader.cxx b/src/daemon/rpmostree-sysroot-upgrader.cxx
@@ -433,13 +433,28 @@ rpmostree_sysroot_upgrader_pull_base (RpmOstreeSysrootUpgrader *self, const char
         if (override_commit)
           return glnx_throw (error, "Specifying commit overrides for container-image-reference "
                                     "type refspecs is not supported");
-        if (check)
-          return glnx_throw (error, "Cannot currently check for updates without downloading");
 
         CXX_TRY_VAR (import,
                      rpmostreecxx::pull_container (*self->repo, *cancellable, r.refspec.c_str ()),
                      error);
         new_base_rev = g_strdup (import->merge_commit.c_str ());
+
+        if (check)
+          {
+            // return glnx_throw (error, "Cannot currently check for updates without downloading");
+            gboolean changed = !g_str_equal (new_base_rev, self->base_revision);
+            if (changed)
+              {
+                rpmostree_output_message ("Difference in commits detected");
+              }
+            else
+              {
+                rpmostree_output_message ("No updates available. Commits are the same");
+              }
+
+            *out_changed = changed;
+            return TRUE;
+          }
         break;
       }
     case rpmostreecxx::RefspecType::Checksum: