daemon: Automatically reload sysroot before txn #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR: coreos#1309 I was hitting race conditions running `ostree admin pin` then `rpm-ostree cleanup` as it was possible that the daemon hadn't handled the inotify on the sysroot and reloaded the deployment state before the txn request came in. Close this race by doing an implicit `reload` before starting a txn. This is a pretty efficient operation because for the sysroot we're just doing a `stat()` and comparing mtime. Implementation wise, change the external API to drop the "did change" boolean as nothing outside of the `sysroot.c` file used it. A followup to this would be changing the `status` CLI to call a (new) DBus API like `RequestReload` that at least did the sysroot reload if the daemon was otherwise idle or so? And it'd be available to unprivileged users.
|
So I built on top of this in #1311, but didn't approve this one yet in case you had a better way of addressing both cases at once. |
|
☔ The latest upstream changes (presumably 706506b) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Included in #1311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: #1309
I was hitting race conditions running
ostree admin pinthenrpm-ostree cleanupas it was possible that the daemon hadn't handledthe inotify on the sysroot and reloaded the deployment state before
the txn request came in.
Close this race by doing an implicit
reloadbefore starting a txn.This is a pretty efficient operation because for the sysroot we're
just doing a
stat()and comparing mtime.Implementation wise, change the external API to drop the "did change"
boolean as nothing outside of the
sysroot.cfile used it.A followup to this would be changing the
statusCLI to call a(new) DBus API like
RequestReloadthat at least did the sysrootreload if the daemon was otherwise idle or so? And it'd be available
to unprivileged users.