Add new D-Bus APIs for deployment finalization #1814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
force-pushed
the
pr/lock-finalization
branch
3 times, most recently
from
126bf71
to
7d8269b
Compare
jlebon
changed the title
|
Ready for review! |
jlebon
force-pushed
the
pr/lock-finalization
branch
from
7d8269b
to
081bee4
Compare
|
Requires: ostreedev/ostree#1841 |
|
bot, retest this please |
|
(Test failure was due to rdgo being broken and testing against a libostree without ostreedev/ostree#1841. Should be fixed now!) |
lucab
reviewed
Apr 26, 2019
jlebon
force-pushed
the
pr/lock-finalization
branch
from
081bee4
to
b9ec996
Compare
|
Fixup! ⬆️ I also changed the transaction type name to |
|
LGTM, just
|
|
This also looks fine to me, but I guess it needs a rebase to master. |
Teach `UpdateDeployment` to make use of libostree's staging lock and then add a `FinalizeDeployment` API to perform the final unlock & reboot. I also added a hidden CLI to make testing this easier, but also because it's likely the FCOS-agent-yet-to-be-named will just end up using the CLI to keep it simple. Closes: coreos#1748
jlebon
force-pushed
the
pr/lock-finalization
branch
from
b9ec996
to
1b5adca
Compare
|
Rebased! ⬆️ |
|
⚡ Test exempted: pull fully rebased and already tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
UpdateDeploymentto make use of libostree's staging lock andthen add a
FinalizeDeploymentAPI to perform the final unlock &reboot.
I also added a hidden CLI to make testing this easier, but also because
it's likely the FCOS-agent-yet-to-be-named will just end up using the
CLI to keep it simple.
Closes: #1748