-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all modularity support #4945
Conversation
Skipping CI for Draft Pull Request. |
ci/test-container.sh
Outdated
koji_kernel_url="https://koji.fedoraproject.org/koji/buildinfo?buildID=2174317" | ||
kver=6.2.8 | ||
koji_kernel_url=https://koji.fedoraproject.org/koji/buildinfo?buildID=2294111 | ||
kver=6.5.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kver=6.5.5 | |
kver=6.8.5 |
ci/test-container.sh
Outdated
url_suffix=2.16.2/2.fc39/x86_64/ignition-2.16.2-2.fc39.x86_64.rpm | ||
# 2.15.0-3 | ||
koji_url="https://koji.fedoraproject.org/koji/buildinfo?buildID=2158585" | ||
koji_kernel_url="https://koji.fedoraproject.org/koji/buildinfo?buildID=2174317" | ||
kver=6.2.8 | ||
koji_kernel_url=https://koji.fedoraproject.org/koji/buildinfo?buildID=2294111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
koji_kernel_url=https://koji.fedoraproject.org/koji/buildinfo?buildID=2294111 | |
koji_kernel_url=https://koji.fedoraproject.org/koji/buildinfo?buildID=2435097 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are testing for the version ID, so either we change that or we use a package from the same version(f40)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks we need to remove:
let modules = extensions.modules.unwrap();
assert!(modules.enable.unwrap().contains("virt:av"));
assert!(modules.install.is_none());
and
let modules = extensions.modules.unwrap();
assert!(modules.enable.as_ref().unwrap().contains("foo:stable"));
assert!(modules.enable.as_ref().unwrap().contains("virt:av"));
assert!(modules.install.is_none())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, happy to see it go. On the origin side, possibly we need code to actually drop the dead keys so they don't just hang around (I mean, it's harmless but it's also misleading).
This is continued in #4937 again. |
They're different, the change in 1ba3a7b just deletes the entrypoints to minimize code churn. This PR deletes it all. |
d496309
to
8a6cb0d
Compare
8a6cb0d
to
dc05dd7
Compare
From failed logs, might need to remove related in
|
Part of https://fedoraproject.org/wiki/Changes/RetireModularity It's dead, so let's remove all the code. I think this may cause things to silently do nothing if folks have modules layered, but at least server side builds will just stop working. Signed-off-by: Colin Walters <[email protected]>
dc05dd7
to
4238364
Compare
OK, if CI passes on this one I think we can call it good to go. |
Derived from #4937
Part of https://fedoraproject.org/wiki/Changes/RetireModularity
It's dead, so let's remove all the code. I think this may
cause things to silently do nothing if folks have modules
layered, but at least server side builds will just stop working.