container: Add spinner/progress for layer fetches #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least gives us a spinner when we're fetching layers, so folks know something is happening. As the comment says we *can* get byte-level progress, but it just needs more plumbing work with our complex internal output infrastructure. Note that I had to move the layer progress bits into a tokio LocalSet because the progress output stuff is a thread local. Signed-off-by: Colin Walters <[email protected]>
2 tasks
cgwalters
commented
May 15, 2024
| output_message(&msg); | ||
| tracing::debug!("layer progress: {msg}"); | ||
| match v { | ||
| ImportProgress::OstreeChunkStarted(_) => { |
There was a problem hiding this comment.
One other tech debt here is that this would all blow up if we started fetching layers concurrently. Ultimately we're going to switch to using podman via containers/bootc#215 so we can ignore this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least gives us a spinner when we're fetching layers, so folks know something is happening.
As the comment says we can get byte-level progress, but it just needs more plumbing work with our complex internal output infrastructure.
Note that I had to move the layer progress bits into a tokio LocalSet because the progress output stuff is a thread local.