Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Continue to write now-empty rpmostree.modules metadata #5069

Merged
merged 1 commit into from
Aug 29, 2024
Merged

core: Continue to write now-empty rpmostree.modules metadata #5069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libpriv/rpmostree-core.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4653,6 +4653,14 @@ rpmostree_context_commit (RpmOstreeContext *self, const char *parent,
g_variant_builder_add (&metadata_builder, "{sv}", "rpmostree.packages",
g_variant_builder_end (pkgs_v));

/* Older versions of rpm-ostree bail if this isn't found:
* https://github.com/coreos/rpm-ostree/issues/5048
* In practice we may as well keep this until the end of time...
*/
auto modules_v = g_variant_builder_new (G_VARIANT_TYPE ("as"));
g_variant_builder_add (&metadata_builder, "{sv}", "rpmostree.modules",
g_variant_builder_end (modules_v));

/* embed packages removed */
/* we have to embed both the pkgname and the full nevra to make it easier to match
* them up with origin directives. the full nevra is used for status -v */
Expand Down
Loading