Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging/rpm-ostree.spec: Update fuse conditional #5082

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Sep 6, 2024

0%{?rhel} matches rhel derived family distros el check seem to break the condition

https://gitlab.com/redhat/centos-stream/rpms/rpm-ostree/-/merge_requests/57#note_2093239477

@cgwalters
Copy link
Member

I still think that's not going to work on Fedora though. Here, I found an example reference:
https://src.fedoraproject.org/rpms/podman/blob/rawhide/f/podman.spec#_14

0%{?rhel} matches rhel derived family distros `el` check seem to break the condition
Plus we need %{defined rhel} to make sure it does not matches fedora.
@jmarrero
Copy link
Member Author

jmarrero commented Sep 6, 2024

I still think that's not going to work on Fedora though. Here, I found an example reference: https://src.fedoraproject.org/rpms/podman/blob/rawhide/f/podman.spec#_14

Thanks, I updated the c10s MR too to make sure both have the results we expect before we merge.

@cgwalters cgwalters merged commit 1864a6b into coreos:main Sep 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants