WIP: kernel-install integration #5097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I only typed this up and made it compile. It's obviously tremendously ugly and will probably catch fire when I try to actually test it. Sending it out so folks can see what I'm thinking. Signed-off-by: Colin Walters <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jmarrero
reviewed
Oct 7, 2024
| @@ -74,7 +73,6 @@ pub fn entrypoint(args: &[&str]) -> Result<()> { | |||
| "yum" | "dnf" => Ok(self::yumdnf::main(host_type, args)?), | |||
| "dracut" => Ok(self::dracut::main(args)?), | |||
| "grubby" => Ok(self::grubby::main(args)?), | |||
| "kernel-install" => Ok(self::kernel_install::main(args)?), | |||
| _ => Err(anyhow!("Unknown wrapped binary: {}", name)), | |||
There was a problem hiding this comment.
This error is triggered now, I am testing with this container file:
FROM quay.io/fedora/fedora-kinoite:40
ADD target/debug/rpm-ostree /usr/bin/rpm-ostree
RUN echo "layout=ostree" > /usr/lib/kernel/install.conf
RUN cat /usr/lib/kernel/install.conf
RUN rpm-ostree override replace https://koji.fedoraproject.org/koji/buildinfo?buildID=2561864
Trying to workaround that next.
|
This will pair with: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 |
|
Closing in favor of #5135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only typed this up and made it compile. It's obviously tremendously ugly and will probably catch fire when I try to actually test it.
Sending it out so folks can see what I'm thinking.
Closes #4726