Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon/transaction-types: Support custom origins for digested pullspecs #5120

Merged
merged 6 commits into from
Oct 16, 2024
Merged

daemon/transaction-types: Support custom origins for digested pullspecs #5120

merged 6 commits into from
Oct 16, 2024

Commits on Oct 7, 2024

  1. rust/core: Add util function to check for digest pullspec 

    Add a new `is_container_image_digest_reference()` function which checks
if the container image pullspec is using a digest.

Prep for next patch.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fe66dea View commit details
    Browse the repository at this point in the history

  2. daemon/transaction-types: Lookup custom origin options earlier 

    Almost no functional change (we do now error out if no description is
given even if we're not going to use those fields, but that seems fine).

Prep for next patch.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ec47f5d View commit details
    Browse the repository at this point in the history

  3. daemon/transaction-types: Support custom origins for digested pullspecs 

    Having a digested pullspec is the container flow equivalent of an
ostree checksum origin. So having a custom origin in that case is useful
there for the same reasons (i.e. it means that something else is likely
managing the host and we want to reflect that info in the origin).

We're thinking of using this in FCOS when we move from OSTree to OCI
for updates.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    83f15d6 View commit details
    Browse the repository at this point in the history

  4. daemon/deployment-utils: Always add custom origin to deployment variant 

    The rebase code already filters out the custom origin bits in cases
where it doesn't make sense, so there's no need to additionally filter
down here.

This makes it work now in both the OSTree checksum case and the
container digested pullspec case.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ae91092 View commit details
    Browse the repository at this point in the history

  5. app/status: Print custom origin for digested pullspecs as well 

    Now that we support this, let's make sure we render it as well.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8009fb1 View commit details
    Browse the repository at this point in the history

  6. tests: Check custom origin with digest pullspec 

    Verify that one can use a custom origin with a digest pullspec. While
we're here, use testing-devel instead of stable since it's going to be
much closer to what we're running on.
    @jlebon
    jlebon committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a65b3af View commit details
    Browse the repository at this point in the history