ci/test-container.sh: Make it easier to execute locally and run treefile-apply test earlier
#5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test right now is cumbersome to run locally. Add a new
`SELF_BOOTSTRAP` env var that allows the test to handle the setup bits
and launching the container.
So with this, you can run the test using:
SELF_BOOTSTRAP=1 ci/test-container.sh
Otherwise, it runs after the `cliwrap` test, which wraps dnf, but we want the real dnf here and it's awkward to try to work around that. The `cliwrap` stuff should probably be tested in a separate run until we remove suppor for it entirely so it doesn't pollute the rest of the test environment.
cgwalters
approved these changes
Feb 8, 2025
cgwalters
reviewed
Feb 8, 2025
| # `SELF_BOOTSTRAP=1 ci/test-container.sh`. | ||
| if [ -n "${SELF_BOOTSTRAP:-}" ]; then | ||
| rm -rf "$PWD/installtree" | ||
| make install DESTDIR="$PWD/installtree" |
There was a problem hiding this comment.
Non blocking but for the future let's use a subdirectory of target/ for this type of stuff because it's already in .gitignore.
There was a problem hiding this comment.
Yeah, agree. This is consistent with tests/vmcheck/install.sh, but we should update both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.