compose: Ensure tempdir is dropped after commit #5339
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tempdir holds the ostree repo. I'm looking at an issue reported in a downstream build that failed like this: ``` + rpm-ostree experimental compose build-chunked-oci --bootc --format-version=1 --rootfs /target-rootfs --output oci-archive:/buildcontext/out.ociarchive Generating commit... error: Generating commit from rootfs: syncfs: Not a directory subprocess exited with status 1 subprocess exited with status 1 ``` Which frankly has me just confused. The `syncfs` here is almost certainly coming from libostree's sync of the target repo. And "Not a directory" is especially weird, implying that `repo/tmp` got swapped with something else? Signed-off-by: Colin Walters <[email protected]>
jeckersb
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tempdir holds the ostree repo.
I'm looking at an issue reported in a downstream build that failed like this:
Which frankly has me just confused. The
syncfshere is almost certainly coming from libostree's sync of the target repo.And "Not a directory" is especially weird, implying that
repo/tmpgot swapped with something else?