fix: tolerate tests that do not specify any headers (#438)

Fixes #437
coreruleset · Jan 3, 2025 · a40d380 · a40d380
1 parent 7806472
commit a40d380
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/ftwhttp/header.go b/ftwhttp/header.go
@@ -111,11 +111,8 @@ func (h Header) WriteBytes(b *bytes.Buffer) (int, error) {
 	return count, nil
 }
 
-// Clone returns a copy of h or nil if h is nil.
+// Clone returns a copy of h
 func (h Header) Clone() Header {
-	if h == nil {
-		return nil
-	}
 	clone := make(Header)
 
 	for n, v := range h {

diff --git a/ftwhttp/request_test.go b/ftwhttp/request_test.go
@@ -289,3 +289,17 @@ func (s *requestTestSuite) TestRequestEncodesPostData() {
 		})
 	}
 }
+
+func (s *requestTestSuite) TestNewRequest_EmptyHeaders() {
+	rl := &RequestLine{
+		Method:  "POST",
+		URI:     "/path",
+		Version: "1.1",
+	}
+
+	req := NewRequest(rl, nil, []byte{}, false)
+
+	headers := req.Headers()
+	s.NotNil(headers)
+	s.Empty(headers)
+}