fix: improve rule ID detection #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use two separate regular expressions to find rule IDs, one for the standard log format, and one for JSON as fallback - be stricter about the format, especially for IDs in JSON Fixes coreruleset#435
This was referenced Jan 3, 2025
M4tteoP
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Looks good to me.
Just for confirmation, this issue has not been introduced by #410, because it is related to the second part of the regex that was |"id":\s*"?(\d+)"?. This PR makes this part stricter and moves it to a new regex. Am I reading this correctly?
|
Yes, the issue would have existed before already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435