Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add documentation about how to do serialization in a separate process #132

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

bchess
Copy link
Contributor

@bchess bchess commented Apr 30, 2024

Write up a discussion of how to do serialization in a subprocess, with a few different examples.

@bchess bchess requested review from wbrown and Eta0 April 30, 2024 18:16
@bchess bchess changed the title Add documentation about how to do serialization in a separate process [docs] Add documentation about how to do serialization in a separate process Apr 30, 2024
Copy link
Contributor

@Eta0 Eta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good content, can add a couple warnings, move the file, and maybe format the code snippets with black/isort

@bchess bchess force-pushed the bchess/subprocess_serialization branch from 50142d1 to 7186238 Compare April 30, 2024 19:44
Copy link
Contributor

@Eta0 Eta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes including a mistake from my last review, whoops.

@bchess bchess merged commit 1552f64 into main Apr 30, 2024
6 of 7 checks passed
@bchess bchess deleted the bchess/subprocess_serialization branch April 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants