Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement photo size parameter #147

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Implement photo size parameter #147

wants to merge 45 commits into from

Commits on Apr 1, 2021

  1. Add documentation for size

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    f6b7338 View commit details
    Browse the repository at this point in the history

  2. Add size documentation for all rovers

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    558bb88 View commit details
    Browse the repository at this point in the history

  3. Rename photos() to search_photos()

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    819ecfa View commit details
    Browse the repository at this point in the history

  4. Permit size

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c709393 View commit details
    Browse the repository at this point in the history

  5. Add photo resizing

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    aeea8e3 View commit details
    Browse the repository at this point in the history

  6. Fix parameter size example

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    4285d09 View commit details
    Browse the repository at this point in the history

  7. Move photo resize methods to helper

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    ce4c7a2 View commit details
    Browse the repository at this point in the history

  8. Refactor and downcase rover_name

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    3c3a67e View commit details
    Browse the repository at this point in the history

  9. Rename private methods for clarity

    mxkay committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    b5d22f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Add error handling to photo resize

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    31f70ae View commit details
    Browse the repository at this point in the history

  2. Fix nested index method

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    953da53 View commit details
    Browse the repository at this point in the history

  3. Add photo resizing to latest_photos_controller

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    d8e4633 View commit details
    Browse the repository at this point in the history

  4. Move search_photos() to PhotoHelper

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    7d03c01 View commit details
    Browse the repository at this point in the history

  5. Permit :size in latest_photos_controller

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    778211a View commit details
    Browse the repository at this point in the history

  6. Make helper methods private and pass params

    mxkay committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    23fc0ac View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Replace include with new helpers.<helper> syntax

    mxkay committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    0c8cd39 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Refactor replace_photo_suffix

    mxkay committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    18c882f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Add and implement lookup_suffix()

    mxkay committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    c471c42 View commit details
    Browse the repository at this point in the history

  2. Isolate sizes to avoid edge case

    mxkay committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    d4eb91c View commit details
    Browse the repository at this point in the history

  3. Update error message

    mxkay committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    ecd8402 View commit details
    Browse the repository at this point in the history

  4. Remove put

    mxkay committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    814fae6 View commit details
    Browse the repository at this point in the history

  5. Refactor resize photo methods to return altered copy of photos

    mxkay committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    69bd885 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Improve error handling

    mxkay committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    13e6e85 View commit details
    Browse the repository at this point in the history

  2. Move search_photos method logic to Photo.search model method

    mxkay committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    57117ff View commit details
    Browse the repository at this point in the history

  3. Improve error handling

    mxkay committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    32d105d View commit details
    Browse the repository at this point in the history

  4. Fix photo suffix capitalization

    mxkay committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    45a6e00 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge branch 'master' into photo-size-parameter

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e9d16c8 View commit details
    Browse the repository at this point in the history

  2. Fix params name conflict

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    0d76781 View commit details
    Browse the repository at this point in the history

  3. Change sequencing of photos to make suffix compatible

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    1508b2e View commit details
    Browse the repository at this point in the history

  4. Add test for photos index with size

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    32d9080 View commit details
    Browse the repository at this point in the history

  5. Simplify test for photos index with size

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    8f196db View commit details
    Browse the repository at this point in the history

  6. Add test for photos show with size

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    66c5b3b View commit details
    Browse the repository at this point in the history

  7. Improve test for photos with size

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    3de4ae7 View commit details
    Browse the repository at this point in the history

  8. Create test for latest_photos_controller

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    80afd8d View commit details
    Browse the repository at this point in the history

  9. Minor change

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    2543edd View commit details
    Browse the repository at this point in the history

  10. Update size parameter documentation

    mxkay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    ac1cdce View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Add test for invalid size parameter

    mxkay committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    c7cff19 View commit details
    Browse the repository at this point in the history

  2. Remove repeated information

    mxkay committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    5db1913 View commit details
    Browse the repository at this point in the history

  3. Change instance variable rover to local variable

    mxkay committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    8b8a50b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Fix code style

    mxkay committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c2cf788 View commit details
    Browse the repository at this point in the history

  2. Raise error for invalid size parameter

    mxkay committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d94eaae View commit details
    Browse the repository at this point in the history

  3. Fix test for invalid size parameter

    mxkay committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d044624 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Improve error output

    mxkay committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    0fca483 View commit details
    Browse the repository at this point in the history

  2. Move search_photos back to PhotoHelper

    mxkay committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    cf164ec View commit details
    Browse the repository at this point in the history

  3. Remove unused code

    mxkay committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    fda4b56 View commit details
    Browse the repository at this point in the history