Native Date & Time Pickers for iOS #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 53. |
Was running into testing errors because accessibility had been updated from a List to a String, so made the corresponding changes
|
Changed accessibility from a List to a String because it was blocking testing and needed to be updated. Tested the code on Android and it worked well. However, on iOS the time and date picker showed up properly but did not actually have a way to save the time/date selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing feature implementing native date and time pickers for iOS
Utilized Dart:io Platform to check for platform OS and if the OS was iOS, I used the iOS date and time picker (CupertinoDatePicker) to show the native pickers
Test Plan
Notes
Problem with getting stuck on loading screen after login, does not have to do with my changes I believe.