Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Journeys Search Bar Bug #230

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Fix Journeys Search Bar Bug #230

merged 3 commits into from
Jan 15, 2025

Conversation

shah-esha
Copy link
Collaborator

@shah-esha shah-esha commented Oct 28, 2024

Fix Journeys Search Bar Bug

This pull request is to fix the Journeys search bar bug, where no results would show for any searches other than "e".

Remaining TODOs:

  • test changes on default journeys

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 28, 2024

[diff-counting] Significant lines: 28.

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

We might want to look into having an EventsPage that JourneysPage and ChallengesPage both extends as there is a lot of commonalities between these two functions.

@BrianLa0616 BrianLa0616 merged commit 0135b1f into master Jan 15, 2025
12 checks passed
@BrianLa0616 BrianLa0616 deleted the journeys-search-bar-bug branch January 15, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants