Release Fixes (Duplicate semesters, broken course menu) (#448)

* Reset sem props for add sem modal * Stop errors if credit range is undefined
cornell-dti · Apr 4, 2021 · 9a389e7 · 9a389e7
1 parent cde918d
commit 9a389e7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/components/Course/Course.vue b/src/components/Course/Course.vue
@@ -26,7 +26,7 @@
       @delete-course="deleteCourse"
       @color-course="colorCourse"
       @edit-course-credit="editCourseCredit"
-      :getCreditRange="getCreditRange"
+      :getCreditRange="getCreditRange || []"
       v-click-outside="closeMenuIfOpen"
     />
   </div>

diff --git a/src/components/Modals/CourseMenu.vue b/src/components/Modals/CourseMenu.vue
@@ -52,7 +52,7 @@
         class="courseMenu-section"
         @mouseover="setDisplayEditCourseCredits(true)"
         @mouseleave="setDisplayEditCourseCredits(false)"
-        v-if="getCreditRange[0] != getCreditRange[1]"
+        v-if="getCreditRange && getCreditRange[0] != getCreditRange[1]"
       >
         <img
           v-if="isLeft"

diff --git a/src/components/Modals/NewSemester.vue b/src/components/Modals/NewSemester.vue
@@ -127,6 +127,7 @@ export default Vue.extend({
       default: null,
     },
     isEdit: { type: Boolean, default: false },
+    isSemesterAdd: { type: Boolean, default: false },
     year: { type: Number, default: 0 },
     type: { type: String as PropType<FirestoreSemesterType>, default: '' },
     isCourseModelSelectingSemester: { type: Boolean, default: false },
@@ -287,6 +288,10 @@ export default Vue.extend({
       } else {
         this.yearText = 0;
       }
+
+      if (this.isSemesterAdd) {
+        this.$emit('updateSemProps', this.seasonPlaceholder, Number(this.yearPlaceholder));
+      }
     },
     resetDropdowns() {
       // reset season dropdown

diff --git a/src/components/Modals/NewSemesterModal.vue b/src/components/Modals/NewSemesterModal.vue
@@ -12,6 +12,7 @@
     <new-semester
       :currentSemesters="semesters"
       :isEdit="false"
+      :isSemesterAdd="true"
       :isCourseModelSelectingSemester="false"
       @duplicateSemester="disableButton"
       @updateSemProps="updateSemProps"