Deploy efficient questions monitoring #890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 41. |
EricWeng23
reviewed
Nov 18, 2024
| const questionData = change.doc.data(); | ||
| const questionId = change.doc.id; | ||
|
|
||
| if (change.type === "modified" && questionData.status === "resolved") { |
There was a problem hiding this comment.
Since this is only removing the questions whose status are resolved and and has been modified, would it be better to first filter the array of docChanges to keep only those that are modified and whose status is resolved. This may be optimal in cases when docChanges is big, thus we can avoid iterating through each change.
anchen9
reviewed
Dec 9, 2024
| if (!isTa && !isProf) { | ||
| const questionsRef = firestore.collection("questions").where("sessionId", "==", session.sessionId); | ||
|
|
||
| unsubscribe = questionsRef.onSnapshot((snapshot) => { |
There was a problem hiding this comment.
Hi Richard! I really like your detailed comment on what the useEffect is, it was very helpful in understanding the useEffect! Overall it looks good to me, but I was wondering if it would be a good idea to handle any potential listening errors for onSnapshot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deploy efficient questions monitoring and a follow-up pr to fix some build issues.
Test Plan
Notes
Breaking Changes
None