Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped launch core #906

Merged
merged 84 commits into from
Nov 22, 2024
Merged

Wrapped launch core #906

merged 84 commits into from
Nov 22, 2024

Conversation

rgu0114
Copy link
Contributor

@rgu0114 rgu0114 commented Nov 22, 2024 •
edited
Loading

@rgu0114 rgu0114 requested a review from a team as a code owner November 22, 2024 00:55
@rgu0114 rgu0114 changed the base branch from master to release November 22, 2024 00:55
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 22, 2024 •
edited
Loading

[diff-counting] Significant lines: 1676. This diff might be too big! Developer leads are invited to review the code.

EricWeng23 and others added 27 commits November 21, 2024 20:37
@EricWeng23 @rgu0114
Final lint fix
f6c2035
@EricWeng23 @rgu0114
Make countZero optional prop
ac978ef
@EricWeng23 @rgu0114
Verified notifications work and fixed build error
9f4d02d
@EricWeng23 @rgu0114
Fixed countdownZero default props error on build
f812259
@EricWeng23 @rgu0114
Fixed default props error in TopBar component
1f6231e
@EricWeng23 @rgu0114
Rerun check
7fdd807
@NIDHI2023 @rgu0114
fixing the red circle's jerkiness
3f4b486
@EricWeng23 @rgu0114
Fixed minor bugs
4c1886f
@EricWeng23 @rgu0114
Fixed build error
0121f4e
@NIDHI2023 @rgu0114
fixing studentData structure
4590e0a
@NIDHI2023 @rgu0114
changed semester to year stuff
930989e
@NIDHI2023 @rgu0114
added hover to dots
8a87a81
@NIDHI2023 @rgu0114
edited selection hover for arrows
ea70a97
@NIDHI2023 @rgu0114
Merge remote-tracking branch 'origin/master' into nidhi/wrapped-testing
236426a
@NIDHI2023 @rgu0114
deleting comment
a7b0084
@NIDHI2023 @rgu0114
wrapped instead of wrapped-fa24
7f317ac
@rgu0114
hide wrapped until opened
15d5e67
@rgu0114
only display countdown and notif bell for hasWrapped === true
6b4375a
@rgu0114
merge
9496a6f
@rgu0114
Merge branch 'master' into richardgu/verify-has-wrapped
e64a9d8
@rgu0114
don't need hasWrapped anymore
ba6c38b
@rgu0114
check fields existing before firebase query
d537288
@rgu0114
corrected code style and total number of slides
547ab62
@rgu0114
Merge branch 'master' into richardgu/wrapped-fe-safety
4796a22
@rgu0114
Merge branch 'master' into richardgu/wrapped-fe-safety
1de1e12
@NIDHI2023 @rgu0114
changing back to plural when counter nums at 0
c2af459
@rgu0114
make sure favTaId exists for students only
c758932
NIDHI2023
NIDHI2023 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@NIDHI2023 NIDHI2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core works for me! great work!

@rgu0114 rgu0114 merged commit 9a5a9c0 into release Nov 22, 2024
4 checks passed
@rgu0114 rgu0114 deleted the wrapped_launch_core branch November 22, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NIDHI2023 NIDHI2023 NIDHI2023 approved these changes

@syoung212 syoung212 Awaiting requested review from syoung212

@thuypham03 thuypham03 Awaiting requested review from thuypham03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rgu0114 @dti-github-bot @NIDHI2023 @achen09 @anchen9 @EricWeng23