Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataflow] Enable csyn for previous design under new use-def chain #281

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

AdrianLiu00
Copy link
Contributor

Description

This PR enables the csyn for previous systolic design and also improves test session.

Problems

Previous design was hard to achieve csyn directly from high-level programming, because the original use-def chain failed to search and mark every target partitioned array. We used to have to add the primitives manually in hls code.

Proposed Solutions

The new use-def chain makes it easy to add partition primitives in the high-level program.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [IR], [Builder], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage (It would be better to provide ~2 different test cases to test the robustness of your code)
  • Code is well-documented

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
davesnx David Sancho
update to upstream
@AdrianLiu00
Copy link
Contributor Author

By the way, I'll try to equip the unified systolic array with multi-cache in the next couple days. Then I will maybe sort out and categorize all the existing systolic designs in the dataflow directory to make it well-organized.

Copy link
Member

@chhzh123 chhzh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@chhzh123 chhzh123 merged commit 3f968a0 into cornell-zhang:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants