Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Setup CI #13

Open
ethanuppal opened this issue Oct 29, 2024 · 4 comments
Open

[ci] Setup CI #13

ethanuppal opened this issue Oct 29, 2024 · 4 comments
Assignees
@Yey007
Labels
dx important Must be resolved quickly

Comments

@ethanuppal
Copy link
Member

We should have a GitHub action that runs make test on each commit and pull request to main.
@ethanuppal ethanuppal added enhancement New feature or request good first issue Good for newcomers important Must be resolved quickly labels Oct 29, 2024
@ethanuppal
Copy link
Member Author

It is also a good idea to have continuous benchmark regression testing.

@ethanuppal
Copy link
Member Author

@Yey007 is this already done?

@Yey007
Copy link
Member

Yey007 commented Dec 6, 2024

No it's half-done lol, test and bench run but bench doesn't actually check for regressions

@Yey007
Copy link
Member

Yey007 commented Dec 6, 2024 •
edited
Loading

TODO

  • Bench that checks for regressions
  • Format linting
  • Do we fail CI on compiler warnings? There are some warnings in the build rn that can easily be avoided
  • Eliminate docs branch if possible

@Yey007 Yey007 added dx and removed enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2024
@ethanuppal ethanuppal changed the title Setup CI [ci] Setup CI Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yey007 Yey007

Labels
dx important Must be resolved quickly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yey007 @ethanuppal